Closed jcuero closed 4 days ago
Thanks for your pull request!
Your pull request does not follow our editorial rules. Could you have a look?
Fixes #NNNNN
) or changelogsThis message is automatically generated by a bot.
/cc @brunobat (opentelemetry), @radcortez (opentelemetry)
Thanks a lot for this!
I agree the problem needs to be fixed, but I am not convinced this is the proper solution. I will spend some time looking into it as I think the way ClientObservabilityHandler
is being used was incorrect from the start.
I am also interested to know if CI passed on your fork with this change
Can you please squash the commits and force push?
I would like to take this out of draft and see what CI says about it, because the more I look at it, the more I think the context handling here is correct
Can you please squash the commits and force push?
I would like to take this out of draft and see what CI says about it, because the more I look at it, the more I think the context handling here is correct
Done!
:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.
Quarkus CI
This is the status report for running Quarkus CI
on commit de6720b495139afd91c04beac83f152687d34067.
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | Initial JDK 17 Build | Build |
Failures | Logs | Raw logs | :mag: |
You can consult the Develocity build scans.
- Failing: independent-projects/resteasy-reactive/client/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 369 more
✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:check (check-imports) on project resteasy-reactive-client: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/resteasy-reactive/client/runtime/src/test/java/org/jboss/resteasy/reactive/client/impl/HandlerChainTest.java
Please do a local build so imports get automatically sorted and the squash changes and push force again.
Quarkus CI
This is the status report for running Quarkus CI
on commit e3dda7efad414acedb1e57525cbbe4dc93e96487.
:white_check_mark: The latest workflow run for the pull request has completed successfully.
It should be safe to merge provided you have a look at the other checks in the summary.
You can consult the Develocity build scans.
@geoand What do you think?
Let's include it but definitely not backport it as this needs a lot of bake time
Thank you so much! @brunobat and @geoand
Thank you!
When combining multiple unis, the operationName field retains the last uni processed instead of retaining the value it was initialized with.