quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.84k stars 2.7k forks source link

Ensure that the name generated in opentelemetry matches the endpoint being called #44523

Closed jcuero closed 4 days ago

jcuero commented 1 week ago

When combining multiple unis, the operationName field retains the last uni processed instead of retaining the value it was initialized with.

quarkus-bot[bot] commented 1 week ago

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

This message is automatically generated by a bot.

quarkus-bot[bot] commented 1 week ago

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

geoand commented 1 week ago

Thanks a lot for this!

I agree the problem needs to be fixed, but I am not convinced this is the proper solution. I will spend some time looking into it as I think the way ClientObservabilityHandler is being used was incorrect from the start.

geoand commented 1 week ago

I am also interested to know if CI passed on your fork with this change

geoand commented 1 week ago

Can you please squash the commits and force push?

I would like to take this out of draft and see what CI says about it, because the more I look at it, the more I think the context handling here is correct

jcuero commented 1 week ago

Can you please squash the commits and force push?

I would like to take this out of draft and see what CI says about it, because the more I look at it, the more I think the context handling here is correct

Done!

quarkus-bot[bot] commented 1 week ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit de6720b495139afd91c04beac83f152687d34067.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs :mag:

You can consult the Develocity build scans.

Failures

:gear: Initial JDK 17 Build #

- Failing: independent-projects/resteasy-reactive/client/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 369 more

:package: independent-projects/resteasy-reactive/client/runtime

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.12.0:check (check-imports) on project resteasy-reactive-client: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/resteasy-reactive/client/runtime/src/test/java/org/jboss/resteasy/reactive/client/impl/HandlerChainTest.java

brunobat commented 1 week ago

Please do a local build so imports get automatically sorted and the squash changes and push force again.

quarkus-bot[bot] commented 1 week ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e3dda7efad414acedb1e57525cbbe4dc93e96487.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

brunobat commented 4 days ago

@geoand What do you think?

geoand commented 4 days ago

Let's include it but definitely not backport it as this needs a lot of bake time

jcuero commented 4 days ago

Thank you so much! @brunobat and @geoand

geoand commented 4 days ago

Thank you!