quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.83k stars 2.7k forks source link

Fix buildpack docker host handling for macos #44543

Closed BarDweller closed 1 day ago

BarDweller commented 6 days ago

Macos has the podman rootless socket at a different location to linux, and the underlying snowdrop library has no smarts to recognise that. This would not be a problem as we offer a way to configure a custom Docker Host, but sadly that route is non-functional.

Overriding Docker Host should be possible via the configuration, but fails because the 'editDockerConfig' call does not retrigger the constructor in the snowdrop library.

This change removes the editDockerConfig call, configuring the library DockerConfig object just once.

Additionally, logic is added to default the docker host value to the env var DOCKER_HOST to work around an unrelated snowdrop library issue.

Finally useDaemon & dockerNetwork are exposed as configuration options in an attempt to provide more options to avoid dockerSocket issues in the future.

BarDweller commented 3 days ago

Fixes #44566

quarkus-bot[bot] commented 3 days ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7b9d7a01cfe81575aaec34ab5d137dbac2c9e655.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

github-actions[bot] commented 3 days ago

🎊 PR Preview bd567a83533f9b25e7d018bdfaeff9d9cabf0de6 has been successfully built and deployed to https://quarkus-pr-main-44543-preview.surge.sh/version/main/guides/

quarkus-bot[bot] commented 3 days ago

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7b9d7a01cfe81575aaec34ab5d137dbac2c9e655.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gsmet commented 1 day ago

Thanks!