search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.83k stars 2.7k forks source link

Add OIDC Redis Token State Manager extension #44546

Closed michalvavrik closed 3 days ago

michalvavrik commented 5 days ago
github-actions[bot] commented 5 days ago

🙈 The PR is closed and the preview is expired.

quarkus-bot[bot] commented 5 days ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b58fe91fdef4086ff495264f7d1099d5ced1f70d.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot[bot] commented 5 days ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b58fe91fdef4086ff495264f7d1099d5ced1f70d.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

:gear: JVM Tests - JDK 21

:package: integration-tests/jpa-oracle

✖ io.quarkus.it.jpa.oracle.JPAFunctionalityTest.testLdapFromServlet - History

``` java.lang.AssertionError: 1 expectation failed. Response body doesn't match expectation. Expected: is "OK" Actual: {"details":"Error id ff08c5bf-6b2c-40e5-bf00-8b5e2d1d0fa8-1, java.sql.SQLException: Acquisition timeout while waiting for new connection","stack":"java.sql.SQLException: Acquisition timeout while waiting for new connection\n\tat io.agroal.pool.ConnectionPool.handlerFromSharedCache(ConnectionPool.java:362)\n\tat io.agroal.pool.ConnectionPool.getConnection(ConnectionPool.java:288)\n\tat io.agroal.pool.DataSource.getConnection(DataSource.java:86)\n\tat io.agroal.api.AgroalDataSource_ARxsrSf_4rhY8Cw6l4pmWY5nZY4_Synthetic_ClientProxy.getConnection(Unknown Source)\n\tat io.quarkus.example.jpaoracle.LdapUrlTestEndpoint.test(LdapUrlTestEndpoint.java:29)\n\tat io.quarkus.example.jpaoracle.LdapUrlTestEndpoint$quarkusrestinvoker$test_056288de5192b9be1916ebef3bf0275a7088b428.invoke(Unknown Source)\n\tat org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(Invocat... ```
michalvavrik commented 4 days ago

Now, I'm wondering about the future. I was planning to extract Redis to a QV repository. I believe this will come with it (as well as the cache implementation). It's not planned for "now", but something for the future.

There is only a couple QV projects I'd use in production. I think you or Sergey needs to decide this because moving it will come with a price. You won't have to just test and release this OIDC Redis extension with every Quarkus release, but also with every QV Redis release. This way, you will have matching tested version for every Quarkus/Redis/OIDC combination. I just checked OIDC Proxy extension in QV and I don't think things are automated in QV side (though I know next to nothing about Quarkiverse). If that will need to be maintained manually, it will be extra work. Maybe you could move it into shared QV project with Redis?

quarkus-bot[bot] commented 4 days ago

:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5e27bb4095875039badceb9a3c40616a5e1b033e.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[!WARNING] There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot[bot] commented 4 days ago

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c3440a4c95fc111e1ea17af261a1664511823c14.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

sberyozkin commented 4 days ago

@calvernaz, FYI

sberyozkin commented 3 days ago

Hi @michalvavrik @cescoffier Apologies I missed the conversation about possible moving of Quarkus Redis Client to Quarkiverse. Yeah, we'll need to decide if the OIDC extension which depends on Redis Client will have to follow it and go to Quarkiverse itself, or may be, we should use this opportunity and figure out how Quarkus externsions living in the main repository can work together with Quarkiverse extensions... Otherwise, if this extension also moves, it is unclear if we have it supported at the product level... It will be an interesting discussion :-)

quarkus-bot[bot] commented 3 days ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c3440a4c95fc111e1ea17af261a1664511823c14.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

:gear: JVM Tests - JDK 21

:package: extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

``` java.lang.AssertionError: Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36) ```