quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.83k stars 2.7k forks source link

Remove customizer mappings from runtime recording Config #44572

Closed radcortez closed 2 days ago

radcortez commented 3 days ago

Caused by #42157.

In #42157, we added https://github.com/radcortez/quarkus/blob/9eff425f2b6ad59e6e205b736ce2611417971d60/core/deployment/src/main/java/io/quarkus/deployment/configuration/BuildTimeConfigBuilderCustomizer.java to register the log config which is required in both build time and runtime.

The customizer now applies to the stripped-down version of a config instance we use to record configuration (where we have to remove the system sources): https://github.com/quarkusio/quarkus/blob/ada7e07ff98abf80371b5f58ebf4bd8e482816a6/core/deployment/src/main/java/io/quarkus/deployment/configuration/BuildTimeConfigurationReader.java#L1101-L1110

This instance does not require any mappings at all, and it is only used to query configuration names to proceed with the recording.

quarkus-bot[bot] commented 2 days ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ada7e07ff98abf80371b5f58ebf4bd8e482816a6.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

:gear: JVM Tests - JDK 17

:package: extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

``` java.lang.AssertionError: Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36) ```