quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.83k stars 2.7k forks source link

Optional `quarkus.config.build-time-mismatch-at-runtime` with default #44598

Closed radcortez closed 1 day ago

radcortez commented 1 day ago

To fix failure found in: https://github.com/quarkusio/quarkus/pull/44588#issuecomment-2488674112

The previous code in https://github.com/quarkusio/quarkus/pull/44559 wouldn't fix it because the mapping itself provides the default. If the mapping is not available, the default wouldn't be either.

quarkus-bot[bot] commented 1 day ago

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 528dc2320433b967a9a54cd8a6a768fefaa2b2bf.

:white_check_mark: The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

:gear: JVM Tests - JDK 17

:package: integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

``` org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167) at org.awaitility.core.CallableCondition.await(CallableCondition.java:78) at org.awaitility.core.CallableCondition.await(CallableCondition.java:26) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975) at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59) at java.base/java.lang.reflect.Method.invoke(Method.java:569) ```

:gear: JVM Tests - JDK 17 Windows

:package: test-framework/junit5-internal

io.quarkus.test.QuarkusProdModeTestConfusingLogTest.shouldWaitForAppActuallyStarted - History

``` org.opentest4j.AssertionFailedError: App's HTTP server is not reachable ==> Unexpected exception thrown: java.net.http.HttpConnectTimeoutException: HTTP connect timed out at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152) at org.junit.jupiter.api.AssertDoesNotThrow.createAssertionFailedError(AssertDoesNotThrow.java:84) at org.junit.jupiter.api.AssertDoesNotThrow.assertDoesNotThrow(AssertDoesNotThrow.java:53) at org.junit.jupiter.api.AssertDoesNotThrow.assertDoesNotThrow(AssertDoesNotThrow.java:40) at org.junit.jupiter.api.Assertions.assertDoesNotThrow(Assertions.java:3187) at io.quarkus.test.QuarkusProdModeTestConfusingLogTest.thenAppIsRunning(QuarkusProdModeTestConfusingLogTest.java:73) at io.quarkus.test.QuarkusProdModeTestConfusingLogTest.shouldWaitForAppActuallyStarted(QuarkusProdModeTestConfusingLogTest.java:49) ```