search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.69k stars 2.65k forks source link

tools and bootstrap in independent-projects should use quarkus parent pom #4911

Open maxandersen opened 4 years ago

maxandersen commented 4 years ago

Burned quite a lot of time the last week because of:

A) dependency-management is not setup similar to quarkus so it takes a lot of hand editing to add what should be simple dependencies (i.e. jackson dataformat)

B) formatting in independent-projects not using ide-config/eclipse-format.xml resulted in back and forth to find right format.

To fix that - rather than setup duplicate of what quarkus parent already do I suggest we move to use quarkus-parent rather than jboss-parent.

maxandersen commented 4 years ago

just tried doing a PR for it and it actually significantly simplifies and reduces the pom.xml files - I'll open one once #4851 is applied as that itself reduced a few things in pom.xml.

stuartwdouglas commented 4 years ago

There is a reason why it was not done this way originally, these projects were intended to be split out into their own repos.

maxandersen commented 4 years ago

just because it is in different repos doesn't prevent use of a common parent bom. i.e. right now they all use jboss parent, but with very little benefit as they duplicate setup and things gets missed.

maxandersen commented 4 years ago

alternative is that we find a way to manually copy all the settings/setup from quarkus parent pom into tools and bootstrap at least as I'm getting tired of having to manually align versions and formatting :)