dynamic overrides of platform descriptor

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.

https://quarkus.io

Apache License 2.0

13.73k stars 2.67k forks source link

dynamic overrides of platform descriptor #8560

Open maxandersen opened 4 years ago

maxandersen commented 4 years ago

Description currently to override support tags we have to do rebuilds - that is not great and causes too many last minute rebuilds. see https://github.com/quarkusio/quarkus-platform/pull/47/files for needed changes.

for now code.quarkus will have a custom hack for specific items, but then cli's etc. would not be able to handle it.

Suggestion is to provide another way of overriding it that is not physically tied to platform.

Implementation ideas could have the platform loading do a basic merge of another json to override metadata like we do during builds.

have explicit just for support tags an external lookup ....

maxandersen commented 4 years ago

@quarkusio/devtools comments/suggestions ?

ia3andy commented 4 years ago

@aloubyansky Maybe that could be done by the resolver?

aloubyansky commented 4 years ago

Platform descriptor resolver? Why not. That or some kind of "decorator" that is pulling the platform descriptor and applies certain adjustments/completes it to be exposed to the end user. To me, it's a "presentation" kind of info, as well as categories, ordering, etc (comparing to other more technical data). It could be kept as a separate desriptor.

ia3andy commented 4 years ago

I think we should question ourselves on the whole process to find the correct solution:

Is the support supposed to be decided before or after a release of the platform?
Could we decide to change it live for an already existing release?
Do we also need that for community overrides?

aloubyansky commented 4 years ago

The issue is about to be able to change this kind of info w/o requiring a new release.

maxandersen commented 4 years ago

Yes. My thinking is separate descriptor.

Status of support level is not something that stays static for any platform.

gastaldi commented 4 years ago

This should be a feature in the extension catalog

maxandersen commented 4 years ago

The catalog would have it and are linked but need be connected to a platform as it’s the thing that defines the support level.

On Sat, 18 Apr 2020 at 15:48, George Gastaldi notifications@github.com wrote:

This should be a feature in the extension catalog

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quarkusio/quarkus/issues/8560#issuecomment-615874831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANG4IMZ3HZRSCQKLET4VDRNGVS5ANCNFSM4MHSLZRA .

-- /max https://about.me/maxandersen