search

quarkusio / quarkus

Quarkus: Supersonic Subatomic Java.
https://quarkus.io
Apache License 2.0
13.38k stars 2.56k forks source link

S2i build and self signed certificates #8947

Open iocanel opened 4 years ago

iocanel commented 4 years ago

Describe the bug

Performing an s2i build using mvn clean install -Dquarkus.container-image.build=true can result is certificate related exceptions, when the server has a self signed certificate.

Expected behavior Build to be triggered or display a warning on how to trust the certificates.

Actual behavior

Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

Note We have something similar in the deploy process: https://github.com/quarkusio/quarkus/blob/55cae6828e6b2d41399786654ee026aa42e0910b/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesDeploy.java#L44

We should also apply this idea for s2i builds too.

geoand commented 4 years ago

@iocanel the exceptions should have been handled: https://github.com/quarkusio/quarkus/blob/f3f85159afe3cffccb8637f6591a791cc945644c/extensions/kubernetes-client/deployment-internal/src/main/java/io/quarkus/kubernetes/client/deployment/KubernetesClientErrorHanlder.java

So obviously there is some kind of issue there :)