quarkusio / quarkusio.github.io

Website for Quarkus project
https://quarkus.io
160 stars 373 forks source link

Fix fallback dev search #1944

Closed ia3andy closed 5 months ago

ia3andy commented 5 months ago

This in combination with https://github.com/quarkusio/search.quarkus.io/pull/238 should fix the local dev search issue.

The idea is to use the production search script and host by default in dev. Using it will result in a 403 leading to using the local search fallback.

ia3andy commented 5 months ago

cc @gsmet @yrodiere @marko-bekhta

github-actions[bot] commented 5 months ago

🎊 PR Preview 661f2f5a60f92d8d9c2ec5830b84ece6f422be52 has been successfully built and deployed to https://quarkus-site-pr-1944-preview.surge.sh

yrodiere commented 5 months ago

@ia3andy Can't you just use staging, since prod will always fail due to CORS?

See https://github.com/quarkusio/search.quarkus.io?tab=readme-ov-file#current-process

ia3andy commented 5 months ago

@yrodiere I also get CORS on staging

yrodiere commented 5 months ago

merged, thanks