search

quarkusio / quarkusio.github.io

Website for Quarkus project
https://quarkus.io
160 stars 373 forks source link

Guides page sorty "by category" isn't filtering when search is empty #1955

Closed insectengine closed 5 months ago

insectengine commented 5 months ago

Describe the bug Guides page sorty "by category" isn't filtering the guides. When the user makes a selection in the pulldown, the content should sort by that category. While it used to do so, it no longer does. The "by Version" works, the "by Category" doesn't.

Which pages https://quarkus.io/guides/

yrodiere commented 5 months ago

@ia3andy I think that's related to your changes no? Currently away, sorry, can't have a look.

ia3andy commented 5 months ago

can you check if the request is alright @marko-bekhta ?

ia3andy commented 5 months ago 

language: en
contentSnippets: 2
contentSnippetsLength: 120
version: latest
categories: messaging
q: rest
page: 0
ia3andy commented 5 months ago

Ah just found that switching category isn't updating the result when search is empty, this is a regression

ia3andy commented 5 months ago

Ok the issue is not that the request and result are wrong, just the regression of changing without searching

marko-bekhta commented 5 months ago

The fix in the component (https://github.com/quarkusio/search.quarkus.io/pull/242) was deployed. But I think quarkus.io has to be rebuilt to pick it up? (since I see that the search component comes from https://quarkus.io/assets/javascript/search-wc.js)

ia3andy commented 5 months ago

The fix in the component (quarkusio/search.quarkus.io#242) was deployed. But I think quarkus.io has to be rebuilt to pick it up? (since I see that the search component comes from https://quarkus.io/assets/javascript/search-wc.js)

yes

marko-bekhta commented 5 months ago

We can close this one, the fix has been deployed for a while now.