search

quarkusio / quarkusio.github.io

Website for Quarkus project
https://quarkus.io
156 stars 365 forks source link

Extract texts from templates #1991

Closed ynojima closed 1 month ago

ynojima commented 1 month ago

Issue: https://github.com/quarkusio/quarkusio.github.io/issues/1990

While localization repositories extracts texts from .adoc and .md files with po4a utility, po4a cannot extract texts from html template files as they contains template directives, which is not valid html tag. To localize texts in html template files, localization repositories have whole html template file instead of just extracted texts. See: https://github.com/quarkusio/ja.quarkus.io/tree/main/l10n/override/ja_JP

This impacts maintenability of lozalization repositories because once original html template files are updated, localized html template files need to be updated even when it doesn't contain texts change.

This commit extracts texts from html template files to yaml files. Once this change is introduced, localization repositories can process yaml files with po4a.

github-actions[bot] commented 1 month ago

🙈 The PR is closed and the preview is expired.

gsmet commented 1 month ago

@ynojima sorry for the delay, I will have a look soon. I totally agree we should do this.

ynojima commented 1 month ago

Thank you! I merged origin/main in 8c14ab5 to resolve conflict.