search

quarkusio / quarkusio.github.io

Website for Quarkus project
https://quarkus.io
160 stars 372 forks source link

fix: set homepage background size to 100% #2037

Closed ricciardelli closed 2 months ago

ricciardelli commented 3 months ago

The background image breaks for resolutions higher than 2352px, which is the width of the image. With this change, the background should not look broken.

Before:

Screenshot 2024-07-02 at 17 49 56

After:

Screenshot 2024-07-02 at 17 50 32
insectengine commented 2 months ago

@ricciardelli - Thank you for pointing out this problem and taking the time to suggest a solution.

This fix causes issues in mobile (this is why we originally changed it). Wasn't able to test at that size noted since I don't have a monitor that large. I've submitted a PR where the image was adjusted to be repeatable in the x-axis and adjusted the CSS.

https://github.com/quarkusio/quarkusio.github.io/pull/2040

maxandersen commented 2 months ago

2040 merged so I think this is out-of-date/duplicate now. Thanks for the pr @ricciardelli !