quarkusio / quarkusio.github.io

Website for Quarkus project
https://quarkus.io
159 stars 372 forks source link

In the docs, redirect to English page should redirect to current page instead of home (https://quarkus.io/) #2048

Closed gian1200 closed 3 weeks ago

gian1200 commented 1 month ago

Description

Due to my browser settings, when navigating from google.com to Quarkus doc, I always get directed to https://es.quarkus.io/XXX. When this happens, a banner appears at the very top of the page, which redirects you tot he English version. However, it doesn't redirects you to current version. Instead, it always redirects you to https://quarkus.io/

image

Steps to reproduce:

  1. Access https://es.quarkus.io/guides/opentelemetry
  2. Clic top link

Expected:

redirect to https://quarkus.io/guides/opentelemetry

Actual:

redirect to https://quarkus.io/

PS: Theme selection (dark, light, system) should be the same across language subdomains (should this be registered in a separate issue?)

Implementation ideas

Just delete the subdomain from current location and redirect to that location. If 404, then redirect to https://quarkus.io/

quarkus-bot[bot] commented 1 month ago

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @rolfedh (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

rolfedh commented 1 month ago

+1 @gian1200

Although the notification serves as a disclaimer that the English website (correct link provided) is the official project site, it would be more helpful if it linked directly to the English version of the same page.

Currently, users can change the language of the guide they are viewing by clicking the Globe icon in the upper right and selecting their preferred language. Can we reuse the code for the English option in the disclaimer?

To see what the user experience is like for a Spanish-speaking user, visit https://es.quarkus.io/guides/ide-tooling.

nikolassv commented 1 month ago

Yes, this should be possible. If no one else is already on this, I will take care of it.

gian1200 commented 3 weeks ago

Closing as this was solved by #2049