search

quarkusio / registry.quarkus.io

Quarkus Extension Registry application
https://registry.quarkus.io
Apache License 2.0
10 stars 11 forks source link

Queries for non-platform extensions will at least match the requested quarkus core version #57

Closed gastaldi closed 2 years ago

gastaldi commented 2 years ago

Fixes #55

gastaldi commented 2 years ago

There is only one drawback for this strategy: newer quarkus versions won't see older quarkiverse releases (eg. quarkus-prettytime won't be visible in 2.5.0.Final unless you release quarkus-prettytime using 2.5.0)

gsmet commented 2 years ago

Well, I think it doesn't fly. We are not releasing new versions of Quarkiverse extensions for each Quarkus version. And there's no way we will do it.

gastaldi commented 2 years ago

@maxandersen any thoughts?

gastaldi commented 2 years ago

I'll provide the quarkus core version fix in a separate PR

aloubyansky commented 2 years ago

There is only one drawback for this strategy: newer quarkus versions won't see older quarkiverse releases (eg. quarkus-prettytime won't be visible in 2.5.0.Final unless you release quarkus-prettytime using 2.5.0)

That was not the idea. If quarkus-prettytime was built with Quarkus 2.4.0.Final it should be included in the catalog based on 2.5.0.Final.

aloubyansky commented 2 years ago

However, the registry should not be always looking at the latest version of a given extension. E.g. if you release prettytime based on 2.6.0.Final, this prettytime release should not be listed in a catalog based on Quarkus 2.5.0.Final. However, for 2.5.0.Final a previous version of prettytime compatible with 2.5.0.Final should be included.

gastaldi commented 2 years ago

However, the registry should not be always looking at the latest version of a given extension. E.g. if you release prettytime based on 2.6.0.Final, this prettytime release should not be listed in a catalog based on Quarkus 2.5.0.Final. However, for 2.5.0.Final a previous version of prettytime compatible with 2.5.0.Final should be included.

Done

maxandersen commented 2 years ago

Why would we need to release every quarkiverse extension?

The idea is a quarkiverse extension shouldn't show up unless there is a release that is at least compatible with a previous version.

Meaning if the first release of quarkiverse-wonka targets quarkus 2.6 it won't show go in quarkus streams older than 2.6 but it will show up in 2.7 and higher.

Currently it shows up for everything which is just not right.