search

quarkusio / registry.quarkus.io

Quarkus Extension Registry application
https://registry.quarkus.io
Apache License 2.0
10 stars 11 forks source link

Introduce unlisted streams #72

Closed gastaldi closed 2 years ago

gastaldi commented 2 years ago

This introduces an unlisted column (default: false) in the platform_stream table along with a new admin endpoint to change its value and uses it in the queries.

Fixes #66

maxandersen commented 2 years ago

So one have to do 2 queries to get all of them ?

gastaldi commented 2 years ago

So one have to do 2 queries to get all of them ?

If you need all streams, you simply invoke the endpoint introduced in #71

maxandersen commented 2 years ago

Okey..what's the usecase of unlisted then ?

gastaldi commented 2 years ago

Having 2.7 and 2.2 streams, once 2.2 is no longer supported, the 2.2 stream must have unlisted set to true

gastaldi commented 2 years ago

See @aloubyansky comments in https://github.com/quarkusio/registry.quarkus.io/issues/66#issuecomment-1020927250

maxandersen commented 2 years ago

okey but why are we calling this "unlisted" as opposed to "recommended" ? jsut seems like a "opposite" api...we aren't unlisting things we are changing the recommendation.

gastaldi commented 2 years ago

Maybe.

At the moment we're listing the streams from the top 2 latest and greatest platform releases. I figured it would be easier in the case where you have two streams to mark the streams that are no longer supported as unlisted from the platform catalog (same nomenclature as when extensions shouldn't be displayed in code.quarkus) instead.

But we can discuss and change if necessary, let's discuss in the next meeting.