quarkusio / registry.quarkus.io

Quarkus Extension Registry application
https://registry.quarkus.io
Apache License 2.0
10 stars 11 forks source link

Display the latest two streams (+ 1 non-stable) + pinned releases #97

Closed gastaldi closed 2 years ago

gastaldi commented 2 years ago

Follow up on #34

gastaldi commented 2 years ago

To test this locally:

1) Run mvn clean compile quarkus:dev 2) Clone the quarkus-extension-catalog repository

git clone https://github.com/quarkusio/quarkus-extension-catalog

3) Run the following command:

jbang catalog_publish@quarkusio --working-directory=./quarkus-extension-catalog --registry-url=http://localhost:8080 --token=test --all

4) Open http://localhost:8080/client/platforms.

You should see 2.8.2.Final, 2.7.5.Final and 2.9.0.CR1 in the produced JSON

aloubyansky commented 2 years ago

George, I think this is not exactly how we want it. We would probably want to keep 2.7 even if we release 2.10.0.Final.

aloubyansky commented 2 years ago

I think the logic you currently have is actually good. I thought we wanted to be able to have some pinned streams in addition to that.

maxandersen commented 2 years ago

Yeah ultimately be able to pin versions and then latest two including optional CR release if exist.

rsvoboda commented 2 years ago

Hi @gastaldi, any plans with this PR for this week?

gastaldi commented 2 years ago

@rsvoboda yes, I'm planning on having another look at it this week

gastaldi commented 2 years ago

Yeah ultimately be able to pin versions and then latest two including optional CR release if exist.

The PR should do that now. You can pin versions in the extension catalog as in: https://github.com/quarkusio/quarkus-extension-catalog/blob/main/platforms/quarkus-bom.yaml#L13-L15 and they will always be included in the list of platforms

gastaldi commented 2 years ago

@aloubyansky any objections? BTW this is the resulting JSON as of now:

{
  "platforms" : [ {
    "platform-key" : "io.quarkus.platform",
    "name" : "Quarkus Community Platform",
    "streams" : [ {
      "id" : "2.8",
      "releases" : [ {
        "version" : "2.8.2.Final",
        "member-boms" : [ "io.quarkus.platform:quarkus-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-optaplanner-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-kogito-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-qpid-jms-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-cassandra-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-amazon-services-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-camel-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-hazelcast-client::pom:2.8.2.Final", "io.quarkus.platform:quarkus-debezium-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-blaze-persistence-bom::pom:2.8.2.Final", "io.quarkus.platform:quarkus-google-cloud-services-bom::pom:2.8.2.Final" ],
        "quarkus-core-version" : "2.8.2.Final"
      } ]
    }, {
      "id" : "2.7",
      "releases" : [ {
        "version" : "2.7.5.Final",
        "member-boms" : [ "io.quarkus.platform:quarkus-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-optaplanner-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-kogito-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-qpid-jms-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-cassandra-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-amazon-services-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-camel-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-hazelcast-client::pom:2.7.5.Final", "io.quarkus.platform:quarkus-debezium-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-blaze-persistence-bom::pom:2.7.5.Final", "io.quarkus.platform:quarkus-google-cloud-services-bom::pom:2.7.5.Final" ],
        "quarkus-core-version" : "2.7.5.Final"
      } ]
    }, {
      "id" : "2.2",
      "releases" : [ {
        "version" : "2.2.5.Final",
        "member-boms" : [ "io.quarkus.platform:quarkus-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-optaplanner-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-kogito-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-qpid-jms-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-cassandra-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-camel-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-hazelcast-client::pom:2.2.5.Final", "io.quarkus.platform:quarkus-debezium-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-blaze-persistence-bom::pom:2.2.5.Final", "io.quarkus.platform:quarkus-google-cloud-services-bom::pom:2.2.5.Final" ],
        "quarkus-core-version" : "2.2.5.Final"
      } ]
    }, {
      "id" : "2.9",
      "releases" : [ {
        "version" : "2.9.0.CR1",
        "member-boms" : [ "io.quarkus.platform:quarkus-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-optaplanner-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-kogito-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-qpid-jms-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-cassandra-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-amazon-services-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-camel-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-hazelcast-client::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-debezium-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-blaze-persistence-bom::pom:2.9.0.CR1", "io.quarkus.platform:quarkus-google-cloud-services-bom::pom:2.9.0.CR1" ],
        "quarkus-core-version" : "2.9.0.CR1"
      } ]
    } ],
    "current-stream-id" : "2.8"
  } ]
}
aloubyansky commented 2 years ago

Let's not pin 2.2, btw.