Closed jwoyame closed 1 year ago
Looks good to me. I haven't tried it out. We could just get ride of that warning if this doesn't fix it.
I definitely appreciate the intent of the warning. It could save a lot of hassle if you actually are using an incompatible store.
The current
isFunction
implementation is:This PR changes it to use
typeof
:This is the implementation advised by the jQuery team.
The current
isFunction
will produce incorrect values for some stores. For example, the AsyncStorage mock module will incorrectly show that it is missing functions:This may be the cause of #96 as well.