search

quarrant / mobx-persist-store

Persist and rehydrate observable properties in mobx store.
270 stars 14 forks source link

Consider renaming useClear and useDisposers to distinguish from React hook #17

Closed codeBelt closed 3 years ago

codeBelt commented 3 years ago

Great library!

I am a React/MobX user and there is a naming convention where React Hooks start with use. Please consider renaming useClear and useDisposers to distinguish from React hook.

The MobX team has done this with useStaticRendering and renamed it to enableStaticRendering.

Deprecate useStaticRendering in favor of renamed enableStaticRendering to distinguish from React hook. https://github.com/mobxjs/mobx-react-lite/pull/302

Some suggests:

quarrant commented 3 years ago

@codeBelt Thank you! Good point! I thought about it