quarrant / mobx-persist-store

Persist and rehydrate observable properties in mobx store.

270 stars 14 forks source link

Fix needed to readme to readStore #21

Closed MaRaSu closed 3 years ago

MaRaSu commented 3 years ago

I also made earlier a mistake of doing JSON parse & stringify in my customer StorageAdapter read & write function before noticing it a few days ago when I switched to Typescript and got the warnings...

16 already fixed the readme for write function. Should do the same for the read function?

BTW great little library!

quarrant commented 3 years ago

@MaRaSu no, the mistake was only in read function

MaRaSu commented 3 years ago

@quarrant we probably mean the same thing...I just wanted to say that readme examples should be corrected also for the readStore function, to complement the fix that you did in issue #16,

quarrant commented 3 years ago

yes, I'll fix it.

Thank you! =)