search

quartiq / miniconf

Rust serialize/deserialize/access reflection for trees (no_std, no alloc)
MIT License
25 stars 3 forks source link

Settings republish events register as updated settings #71

Closed ryan-summers closed 2 years ago

ryan-summers commented 2 years ago

When miniconf republishes settings, it registers the message that it has published as inbound change requests. This causes it to generate settings update events for all settings.

jordens commented 2 years ago

Yeah. We should probably not just stall incoming messages but actually discard reject them. Or mark them (republication messages) with a property as application-originating and discard based on that?

ryan-summers commented 2 years ago

We could theoretically append some CorrelationData indicating that they are republished messages.

While we can modify the Miniconf state machine to just reject/ignore any inbound settings configurations while doing republishing, this doesn't solve the problem completely since we would transition state after republishing the last setting, which then causes us to re-receive it. I think correlation data is likely the best approach.