search

quartiq / phaser

Phaser AWG DSP design
GNU General Public License v3.0
10 stars 5 forks source link

code formatting #20

Closed nkrackow closed 2 years ago

nkrackow commented 2 years ago

I simply ran black on all the files. Not tested if it still runs/synthesizes as before but probably should?

jordens commented 2 years ago

I'm ok with the result. It hurts the readability of the If() but that is outweighed IMO by the consistency gain and simply quenching all uncertainty about formatting. Maybe a quick fix would be to introduce If(condition).Then(block).Elif(condition).Then(block).Else(block) in migen.

If it synthesizes, that should be enough.

nkrackow commented 2 years ago

I checked and it synthesizes fine. I'll merge the PR then ok?

jordens commented 2 years ago

Ah. Could you compare the verilog of with and without this patch? It should be exactly equal. If yes, this is good to merge.

nkrackow commented 2 years ago

Checked with git diff and its exactly equal.