search

quarto-dev / quarto-actions

GNU General Public License v2.0
228 stars 53 forks source link

quarto-dev/quarto-actions/publish@v2 is clobbering my CNAME in gh-pages branch #73

Closed andrewcstewart closed 1 year ago

andrewcstewart commented 1 year ago

Recently each time I run quarto-dev/quarto-actions/publish@v2 my custom domain for my gh-pages deployment gets clobbered. Looking in the gha log I spot the following:

delete mode 100644 CNAME

Not sure if there's already a mechanism to tell the action to not delete that file, but it might be a good idea to include an option like https://github.com/marketplace/actions/github-pages-action#%EF%B8%8F-add-cname-file-cname

cscheid commented 1 year ago

I think this needs to solved by the quarto publish command. We simply ensure the contents of the branch match the contents of _site, and the publish action is simply orchestrating that.

cscheid commented 1 year ago

A related question: could you add the CNAME file to your quarto repo?

cderv commented 1 year ago

FWIW this was also mentioned and discussed in https://github.com/quarto-dev/quarto-cli/discussions/3249

allenmanning commented 1 year ago

FWIW this was also mentioned and discussed in quarto-dev/quarto-cli#3249

Is this a duplicate?

cderv commented 1 year ago

Is this a duplicate?

Yes probably. One is a discussion item, and this one is an issue. However, I believe the solution given in the discussion is the one to follow.

cderv commented 1 year ago

@andrewcstewart does the solution provided works ok for you ?

Thank you

andrewcstewart commented 1 year ago

Doh, why didn't I think of that? Yes that would work fine.