VS Code columns snippet provided non-valid code

quarto-dev / quarto

Quarto open-source scientific and technical publishing system

https://quarto.org

GNU Affero General Public License v3.0

280 stars 19 forks source link

VS Code columns snippet provided non-valid code #428

Open EmilHvitfeldt opened 1 month ago

EmilHvitfeldt commented 1 month ago

Both the columns2 and columns3 end the last block with , which is not renderable by quarto.

Reprex

---
---

## With comment

::: {.columns}
::: {.column}
:::
::: {.column}
:::
::: <!-- end columns -->

## Without comment

::: {.columns}
::: {.column}
:::
::: {.column}
:::
:::

Result

Snippet specification for reference: https://github.com/quarto-dev/quarto/blob/3bd070a1ffabd0b2dc80c67f5d9fa9a2d8bee896/apps/vscode/snippets/quarto.code-snippets#L133-L166

cscheid commented 1 month ago

We should definitely add a newline there...