quarto-ext / fontawesome

Use Font Awesome icons in HTML and PDF documents.
MIT License
105 stars 10 forks source link

More icons? #1

Closed eitsupi closed 2 years ago

eitsupi commented 2 years ago

Hi, thank you for this great extension.

Do you have information on which icons are included? For example, rabbit does not seem to be available.

eitsupi commented 2 years ago

It seems that we can only use icons which have solid?

https://github.com/quarto-ext/fontawesome/blob/a5baffa1f22f735469bf3b24a77e6f8d99007797/_extensions/fontawesome/fontawesome.lua#L26

mcanouil commented 2 years ago

Indeed, I tried to use brands icons, but because "fa-solid" is hardcoded it is not possible.

See https://github.com/RLille/rlille.fr/pull/12 and Netlify preview

image
jjallaire commented 2 years ago

Just added support for the brands prefix. Updated docs here:

https://github.com/quarto-ext/fontawesome

Note that only the free fontawesome icons are supported, and rabbit does not appear to be a free icon. You could use it by purchasing a Pro plan and then overwriting the assets directory within the extension with the Pro icons.

eitsupi commented 2 years ago

Thank you for updating immediately. Do you have any plans for release?

mcanouil commented 2 years ago

@eitsupi When you install the extension you get the HEAD of the repository. I already reinstalled the extension and used it for https://rlille.fr (To note, at first there was a weird behaviour, so I updated Quarto to the latest and it works smoothly).

eitsupi commented 2 years ago

When you install the extension you get the HEAD of the repository.

Thanks pointing this out. It works! (Perhaps there is currently no way to specify tags?)

By the way, the font list seems to include regular but the following code did not work. Am I missing something?

{{< fa regular arrow-up-right-from-square >}}

https://fontawesome.com/icons/arrow-up-right-from-square?s=regular

dragonstyle commented 2 years ago

Thanks pointing this out. It works! (Perhaps there is currently no way to specify tags?)

We are working on documentation for extensions now, but you can use tags as well, like:

quarto install extension quarto-ext/fontawesome@<tagname>

eitsupi commented 2 years ago

We are working on documentation for extensions now, but you can use tags as well, like:

quarto install extension quarto-ext/fontawesome@<tagname>

Thank you for letting me know. Makes sense, as this is a common way of specifying! (I tried it but forgot the v and it failed, so I mistakenly thought it couldn't be done......)

dragonstyle commented 2 years ago

It's great to have you using all of this, thank you!

mcanouil commented 2 years ago

{{< fa regular arrow-up-right-from-square >}}

@eitsupi This one is not amongst the 2,009 free icons (See https://fontawesome.com/search?m=free). {{< fa regular share-from-square >}} works for instance.

eitsupi commented 2 years ago

This one is not amongst the 2,009 free icons (See fontawesome.com/search?m=free). {{< fa regular share-from-square >}} works for instance.

Thanks, I finally understand.......

image image

mcanouil commented 2 years ago

I doubled check and apparently light/thin aren't free^^ image

Only 162 out of the 2,009 free icons have "regular" form available