Accessiblity - Githubissues

quarto-ext / fontawesome

Use Font Awesome icons in HTML and PDF documents.

https://quarto-ext.github.io/fontawesome/

MIT License

109 stars 10 forks source link

Accessiblity #12

Closed mcanouil closed 2 years ago

mcanouil commented 2 years ago

This PR does:

Improve accessibility (#8):
- Adds aria-label attribute.

cscheid commented 2 years ago

Let's not do the license change on this one, because if we do that, we want to synchronize that change along all extensions in quarto-ext. Can you revert that part, please?

cscheid commented 2 years ago

(I somehow was missing some notifications on this repo. Sorry about the delay. This looks good.)

mcanouil commented 2 years ago

I was hoping for someone to confirm screen reader was working before merging, thus draft, although the changes can not hurt anyway.

I tried the MacOS screen reader on different syntax, but it does not seem to work or I am mistaken about how it's suppose to work, so I stayed to the current one in that branch based on several accessibility recommendations.

cscheid commented 2 years ago

Ok, thanks for the added context.