search

quarto-ext / fontawesome

Use Font Awesome icons in HTML and PDF documents.
MIT License
105 stars 10 forks source link

FontAwesome 6.4.2 Update #32

Closed bpkleer closed 1 year ago

bpkleer commented 1 year ago

Dear all,

I saw that the issue and task for implementing 6.4.2 is still open (https://github.com/quarto-ext/fontawesome/issues/28). Since I needed 6.4.2 support for my presentation (new twitter logo), I updated the .css-files to 6.4.2 and the ttf/woff2 files. In case this might help you or is interesting to you, use it!

All the best Phil

cscheid commented 1 year ago

Hey Phil, this looks excellent, thank you so much! I think that for larger PRs like this, we need you to file a contributor agreement with Posit. Can you follow the instructions on https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md and confirm on a reply here that you've done so?

bpkleer commented 1 year ago

Hey Carlos,

please find attached the document (I put the email-address from contributing in CC). So, I need to re-do the pull request according to contributin.md, right?

All the best Phil



Am 22.09.2023 um 17:07 schrieb Carlos Scheidegger @.***>:

Hey Phil, this looks excellent, thank you so much! I think that for larger PRs like this, we need you to file a contributor agreement with Posit. Can you follow the instructions on https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md and confirm on a reply here that you've done so?

— Reply to this email directly, view it on GitHub https://github.com/quarto-ext/fontawesome/pull/32#issuecomment-1731581851, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARI2FFOTVNNOFXW74C6LRATX3WSUFANCNFSM6AAAAAA5DF5MAM. You are receiving this because you authored the thread.

cscheid commented 1 year ago

No, no need to redo the pull request!

cscheid commented 1 year ago

LGTM, thanks for the contribution!

bpkleer commented 1 year ago

You’re welcome. I heavily use it. Thanks for providing and maintaining it!

Am 22.09.2023 um 19:19 schrieb Carlos Scheidegger @.***>:

LGTM, thanks for the contribution!

— Reply to this email directly, view it on GitHub https://github.com/quarto-ext/fontawesome/pull/32#issuecomment-1731775917, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARI2FFMEPKT7YDG4IAJPCSDX3XCBBANCNFSM6AAAAAA5DF5MAM. You are receiving this because you authored the thread.