search

quarto-ext / fontawesome

Use Font Awesome icons in HTML and PDF documents.
MIT License
105 stars 10 forks source link

Feature/fontawesome6 #33

Closed bpkleer closed 1 year ago

bpkleer commented 1 year ago

Hey @cscheid ,

I just recognized that I got lost in my files and uploaded the wrong all.css (that does no included all icons). I corrected it and here is the correct file.

cscheid commented 1 year ago

Huh. This is interesting, because I did test your previous change and I saw the x-twitter icon.

Is there a test that could have found the difference?

bpkleer commented 1 year ago

I actually don’t know. I was working with the file from fortawesome/fontawesome. And I guess in some of my work I deleted too much, since the file from yesterday has a couple hundred files less.

Am 23.09.2023 um 17:52 schrieb Carlos Scheidegger @.***>:

Huh. This is interesting, because I did test your previous change and I saw the x-twitter icon.

Is there a test that could have found the difference?

— Reply to this email directly, view it on GitHub https://github.com/quarto-ext/fontawesome/pull/33#issuecomment-1732347398, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARI2FFJEFFL2IZ3WE5AO3H3X34AVFANCNFSM6AAAAAA5ECINRU. You are receiving this because you authored the thread.

cscheid commented 1 year ago

Ok. This is unfortunate, but we'll merge. I might contact you again should someone else find a bug :)