Refactor branch 2.5, clean code

bcode2 commented 1 month ago

This PR...

Fixes issue #

Changes

refactor: replace while loop with enhanced for loop refactor: language migration; simplify maps operations style: improve visibility change l by L for long literals refactor: replace addAll() with parameterized constructor refactor: set serialVersionUID fields as static and final refactor: language migration, remove unnecessary boxing refactor: language migration, use lambda expression to simplify code and remove unused imports refactor: remove redundant variable declaration performance: language migration refactor: simplify boolean expression

Checklist

[x] tested locally
[ ] updated the docs
[ ] added appropriate test
[x] signed-off on the DCO referenced in the CONTRIBUTING link below via git commit -s on my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners (If you're not using command-line, you can use a browser extension )

In submitting this contribution, I agree to the terms of contributing as referred to here: https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

jhouserizer commented 1 month ago

Can you help me understand where this all stands at this point?

bcode2 commented 1 month ago

Can you help me understand where this all stands at this point?

Hi @jhouserizer give me a second . I guess I have already addressed all comments. Will rollback one of those that are still unfixed to allow you to merge it. In another smaller PR will try to fix those referenced by @chrisdennis and @melloware

bcode2 commented 1 month ago

Well @jhouserizer , @chrisdennis I guess everything has been solved

quartz-scheduler / quartz