feat: implementing cv06

benfdking commented 1 month ago

temp
temp
tempt
temp

github-actions[bot] commented 1 month ago

Benchmark for 830bafd

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | 142.7±5.01µs | 143.8±7.60µs | +0.77% | | fix_complex_query | **13.4±0.05ms** | 13.6±0.44ms | **+1.49%** | | parse_complex_query | 4.3±0.05µs | 4.3±0.06µs | 0.00% | | parse_expression_recursion | 7.3±0.39µs | 7.2±0.14µs | -1.37% | | parse_simple_query | **1392.2±16.05ns** | 1471.0±28.93ns | **+5.66%** |

github-actions[bot] commented 1 month ago

Benchmark for ebec412

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | 143.3±2.81µs | 141.7±2.85µs | -1.12% | | fix_complex_query | 13.7±0.34ms | **13.6±0.08ms** | **-0.73%** | | parse_complex_query | **4.3±0.06µs** | 4.4±0.06µs | **+2.33%** | | parse_expression_recursion | **7.2±0.11µs** | 7.3±0.08µs | **+1.39%** | | parse_simple_query | **1413.3±15.05ns** | 1430.1±62.35ns | **+1.19%** |

github-actions[bot] commented 1 month ago

Benchmark for af2e359

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | **140.6±1.49µs** | 143.1±7.94µs | **+1.78%** | | fix_complex_query | 13.5±0.28ms | 13.5±0.10ms | 0.00% | | parse_complex_query | 4.2±0.05µs | 4.2±0.10µs | 0.00% | | parse_expression_recursion | 7.1±0.06µs | 7.1±0.10µs | 0.00% | | parse_simple_query | 1390.6±32.69ns | 1372.4±24.63ns | -1.31% |

github-actions[bot] commented 1 month ago

Benchmark for 2e5ddc2

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | 143.4±3.14µs | 143.3±2.43µs | -0.07% | | fix_complex_query | **13.4±0.13ms** | 13.7±0.22ms | **+2.24%** | | parse_complex_query | 4.3±0.06µs | 4.3±0.06µs | 0.00% | | parse_expression_recursion | 7.2±0.05µs | 7.2±0.10µs | 0.00% | | parse_simple_query | 1431.3±26.46ns | 1426.4±65.50ns | -0.34% |

github-actions[bot] commented 1 month ago

Benchmark for 53007a1

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | 143.3±6.35µs | 144.2±1.23µs | +0.63% | | fix_complex_query | **13.4±0.43ms** | 13.5±0.09ms | **+0.75%** | | parse_complex_query | 4.3±0.05µs | 4.3±0.10µs | 0.00% | | parse_expression_recursion | 7.1±0.10µs | 7.1±0.05µs | 0.00% | | parse_simple_query | 1409.4±63.79ns | 1442.3±77.80ns | +2.33% |

gvozdvmozgu commented 1 month ago

@benfdking

github-actions[bot] commented 1 month ago

Benchmark for 3efe86e

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | DepthMap::from_parent | **140.1±1.12µs** | 143.7±5.23µs | **+2.57%** | | fix_complex_query | 13.4±0.35ms | 13.5±0.19ms | +0.75% | | parse_complex_query | 4.3±0.07µs | 4.3±0.05µs | 0.00% | | parse_expression_recursion | 7.5±0.09µs | **7.1±0.11µs** | **-5.33%** | | parse_simple_query | **1370.7±20.83ns** | 1418.2±18.15ns | **+3.47%** |

benfdking commented 1 month ago

Any chance you can try to explain what you did? My understanding is that it was "seeking" through the file multiple times and thus you ended up with "multiple" identical fixes?

gvozdvmozgu commented 1 month ago

There were errors in the arguments that were passed, and some conditions were inaccurate.

As far as I remember:

If self.require_final_semicolon was active, segment was passed instead of context.segment.
If it was not empty, a lint was created even though it consisted of comments or spaces.
There was an incorrect selection of segments (it seems that in before_code, there was just is_code instead of !is_code).

I don't remember much else.

quarylabs / sqruff