quarzoliquido / es-operating-system

Automatically exported from code.google.com/p/es-operating-system
Apache License 2.0
0 stars 0 forks source link

Code review request #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Purpose of code changes on this branch:
limited listen queue length support.

When reviewing my code changes, please focus on:
1183

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by ailvpen...@gmail.com on 6 Aug 2009 at 4:04

GoogleCodeExporter commented 9 years ago
Most of your code looks good to me, but I have a comment on
StreamReceiver::StateListen::input(). When the listen queue length exceed the 
limit,
we should call accepted->abort() before return with false.

Please commit this change to the trunk after dealing with avobe comment.

Original comment by Ishibash...@gmail.com on 8 Aug 2009 at 5:06

GoogleCodeExporter commented 9 years ago
Thank you Kenichi,
I have fixed StreamReceiver::StateListen::input() in r1187, and commit to the 
trunk
in r1189

Original comment by ailvpen...@gmail.com on 10 Aug 2009 at 9:24

GoogleCodeExporter commented 9 years ago
Thank you Shiki,

Sorry, I see your comment after I commit to the trunk.
Please revert this commit to the trunk,that is r1189 

Original comment by ailvpen...@gmail.com on 10 Aug 2009 at 1:26

GoogleCodeExporter commented 9 years ago

Original comment by Ishibash...@gmail.com on 13 Aug 2009 at 9:19