quasar / Quasar

Remote Administration Tool for Windows
MIT License
8.8k stars 2.49k forks source link

[CTRL+Shift+any letter] keylogging #98

Closed DragonzMaster closed 9 years ago

DragonzMaster commented 9 years ago

when trying to press ctrl+z (as an example) it is logged correctly but when trying to press [CTRL+Shift+any letter] it don't log shift key but instead of that it capitalize the letter example : when i press [CTRL+Shift+z] it is logged [CTRL-Z] and the same issue when i press [ALT+Shift+z] is logged [ALT-Z] - with the letter capitalized

OpenSourceCS commented 9 years ago

yes please implement this as well as some other keylogger improvements such as #95(Keylogger escape key).

yankejustin commented 9 years ago

Please try my fix and see if it resolves your problem.

OpenSourceCS commented 9 years ago

I have added a note in ur fix @yankejustin .Please check 96 95 94 90 85

yankejustin commented 9 years ago

Please don't reference issues opened too much. It makes it confusing for me to resolve them (as I check to make sure nobody else is also working on it). I am trying to resolve them all. ;)

yankejustin commented 9 years ago

If someone could give me the OK for my changes, I will send the pull request in. Unfortunately can't check at this moment. :100:

ghost commented 9 years ago

I'll check in a few minutes, nice code btw :)

yankejustin commented 9 years ago

Thank you very much. :)

yankejustin commented 9 years ago

I am devising a better way to fix this, but I will implement it later tonight after thinking it over more.

OpenSourceCS commented 9 years ago

would be nice if we add arrow keys.

Some people type their passwords one character back and forth. so implementing arrow keys might be useful.

VK_ codes are 37, 38, 39,40 Print Screen is 44.

OpenSourceCS commented 9 years ago

I think pressing shift and any letter(say l) for captializing it would result in [Shift + L].

yankejustin commented 9 years ago

@MaxXor If possible, please assign this to me.

DragonzMaster commented 9 years ago

the problem shoud be solved by checking if the ctrl or alt pressed + shift so the shift key should be logged else (shift + any letter) shoud capitalize the letter only and don't log shift key

yankejustin commented 9 years ago

Hello all! I have made many updates. It won't be functional until tomorrow, but I would love it if I got some help adding some attributes for the KeyloggerKeys :) https://github.com/yankejustin/xRAT

ghost commented 9 years ago

@yankejustin, Good work. I've pushed a commit to your branch with some additional attributes. I didn't add attribute members for all of the keys, only the ones I felt were necessary.

yankejustin commented 9 years ago

@d3agle Thank you! Just be sure to make the other parameter (the optional one) true so it will highlight special keys like function keys. Example: Instead of logging f1 It would log [f1] with the highlights. :) The attribute would be [KeyloggerKey("F1", true)]

yankejustin commented 9 years ago

@d3agle Thank you for the contribution. :+1:

ghost commented 9 years ago

No problem and sorry I forgot to add those, just pushed a commit

DragonzMaster commented 9 years ago

good work guys @yankejustin @d3agle both of you made great efforts thnx

yankejustin commented 9 years ago

@MaxXor This one can be closed because it is no longer an issue in the new branch. :)