Closed dobromir-hristov closed 6 years ago
No. If provided with an absolute path, like we do now, it only looks for shallow level deps. It requires that string to actually look deeply into dependencies.
Hi Dobromir,
Sorry for taking so long. Currently focusing on v1.0, so please bare with me a little more until I properly review, merge and publish. Thanks for this PR.
Thanks for investigating and providing a PR!
;) Always bud.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Fixes an issue where Webpack was not loading dependencies that were nested inside package's node_modules reported in #197
Details: When two packages share a common package, but with different versions, one of the packages gets a nested
node_modules
holding the required version of the package it depends on.The lack of
node_modules
string means that Webpack will only do a shallow look for packages inside the specified absolute paths.The change is tested locally and is checked against resources like the Vue CLI, where they do the same.