quasarframework / quasar-cli

[DEPRECATED, <= 0.17) Quasar Framework - CLI
https://quasar.dev
MIT License
202 stars 50 forks source link

fix: #197 Webpack does not load nested dependencies #198

Closed dobromir-hristov closed 6 years ago

dobromir-hristov commented 6 years ago

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

Other information:

Fixes an issue where Webpack was not loading dependencies that were nested inside package's node_modules reported in #197

Details: When two packages share a common package, but with different versions, one of the packages gets a nested node_modules holding the required version of the package it depends on.

The lack of node_modules string means that Webpack will only do a shallow look for packages inside the specified absolute paths.

The change is tested locally and is checked against resources like the Vue CLI, where they do the same.

dobromir-hristov commented 6 years ago

No. If provided with an absolute path, like we do now, it only looks for shallow level deps. It requires that string to actually look deeply into dependencies.

rstoenescu commented 6 years ago

Hi Dobromir,

Sorry for taking so long. Currently focusing on v1.0, so please bare with me a little more until I properly review, merge and publish. Thanks for this PR.

rstoenescu commented 6 years ago

Thanks for investigating and providing a PR!

dobromir-hristov commented 6 years ago

;) Always bud.