search

quasarframework / quasar-starter-kit

Quasar CLI Starter Kit
https://quasar.dev
MIT License
104 stars 70 forks source link

Support TS properly for other ESLint presets and/or make Prettier the recommended TS preset #170

Open yusufkandemir opened 2 years ago

yusufkandemir commented 2 years ago

Is your feature request related to a problem? Please describe. Current ESLint presets are supporting TS. But, you can experience some problems as you start writing more code. abraxxa#9791 from our community Discord server reported that defining enums are ending up with the no-unused-vars error. So, I decided to investigate a bit and found out that StandardJS and Airbnb don't 100% cover TS out of the box.

Describe the solution you'd like Install and configure https://github.com/standard/eslint-config-standard-with-typescript for StandardJS and https://github.com/iamturns/eslint-config-airbnb-typescript for Airbnb.

Since this can increase the complexity and maintenance burden of this project, just marking Prettier as recommended would be a fine choice as well. Even if we end up improving the other presets, I personally think we should make Prettier the recommended preset for TS, because it'll always work as-is and the code style is closer to what the TS community uses.

Describe alternatives you've considered Adjusting a few rules when needed. Manually installing those presets when needed.

Additional context

IlCallo commented 2 years ago

I think the best way would be to support the TS enhancements for standard and airbnb I think I already tried doing that but stopped before adding a PR, but cannot recall why I stopped

Prettier is already the implicit recommended option, as it has been moved to the top of ESLint preset selection, so I don't think adding a (Recommended) would convince other people moving away from their preferred preset