Open gtrombitas opened 2 years ago
Thanks for the contribution :) I don't have time to test it right now, but I left some comments on what seems to be off at a first glance
@IlCallo I fixed the requested changes please check them.
hi @gtrombitas, and thanks for the PR, I have run some tests on it.
Coverage of .ts
files is perfect, but .vue
files seem to have some issues, it seems all files are getting the exact same coverage, with the same uncovered block position (see screens).
@maiolica Thank you for the review and testing effort. Unfortunately I couldn't find any other solutions to handle .vue
file instrumentation better.
I opened an issue to coverage-istanbul-loader library: link
Hopefully they can advise a concrete solution or a workaround for this problem.
I'm regularly checking that issue, but the project seems abandoned since 2020 The whole Instanbul ecosystem seems freezed in time right now
Is there any reliable alternative into JS ecosystem?
Thanks for the sync-up. Yes, I have seen the same thing at Istanbul repo. Unfortunately I'm not familiar with any other alternatives to this library. When I have a little time for it then I'll try to look into some other libs. If something already exists at all...
What kind of change does this PR introduce? (check at least one)
If you are adding a new test runner, have you...? (check all)
/packages/base/runners.json
?/README.md
?baseline.spec.vue
?Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: