search

quasarframework / quasar-testing

Testing Harness App Extensions for the Quasar Framework 2.0+
https://testing.quasar.dev
MIT License
179 stars 65 forks source link

Cypress Configuration Style import order #302

Closed devidw closed 1 year ago

devidw commented 1 year ago

Software version

OS: macOS Node: v18.11.0 PNPM: 7.15.0

Details

When doing component testing with cypress, some custom styles do not apply.

The default generated config in /test/cypress/support/component.ts is:

// Change this if you have a different entrypoint for the main scss.
import 'src/css/app.scss'
// Quasar styles
import 'quasar/src/css/index.sass'

However, when overriding Quasar styles withing the custom entry point, they have a lower priority and therefore Quasar built-in styles are loaded over those custom ones.

Would it make more sense to swap the order to import Quasar first and Custom afterwards.

At least this fixes my styling issues.

Please correct me, if I am missing something here.

IlCallo commented 1 year ago

I think you're right, can you create a PR to fix this by switching the imports both in typescript and no-typescript templates, as well as into all test-projects scaffolded files?

devidw commented 1 year ago

Sure thing: https://github.com/quasarframework/quasar-testing/pull/303

IlCallo commented 1 year ago

Thanks for contributing! Keep going if you find any other problem 😁