search

quasarframework / quasar-testing

Testing Harness App Extensions for the Quasar Framework 2.0+
https://testing.quasar.dev
MIT License
179 stars 65 forks source link

bug: npm run test:unit should not updateSnapshot for jest #310

Closed glorat closed 1 year ago

glorat commented 1 year ago

https://github.com/quasarframework/quasar-testing/blob/6b8a66d00b1352d4024d39ebff82f68163864b05/packages/unit-jest/src/install.js#L89

glorat commented 1 year ago

Correct should probable be 'test:unit': 'jest --ci'

updateSnapshot is obviously wrong since that will always update snapshots and never fail

IlCallo commented 1 year ago

Nope, test:unit:ci is the one for that Not sure why it has --updateSnapshot, possibly because that's meant to be run while developing, so where stuff can change pretty often? I'll remove it, as it doesn't seem to make sense as you pointed out, thanks