search

quasarframework / quasar-testing

Testing Harness App Extensions for the Quasar Framework 2.0+
https://testing.quasar.dev
MIT License
179 stars 66 forks source link

Support `eslint-plugin-cypress: ^4.0.0` for `quasar-app-extension-testing-e2e-cypress` #386

Open FelixNumworks opened 1 month ago

FelixNumworks commented 1 month ago

Currently, quasar-app-extension-testing-e2e-cypress has a peerDepency to "eslint-plugin-cypress": "^2.12.1" I'd like to bump eslint-plugin-cypress to 4.0.0 :/

yusufkandemir commented 4 days ago

quasar-app-extension-testing-e2e-cypress just installs eslint-plugin-cypress when the AE gets installed. So, it shouldn't be a peer dependency in the first place.

As for your case, you should be able to safely upgrade eslint-plugin-cypress version and ignore the peer dependency warning, or suppress it if it's an error, depending on your package manager configuration.

Just a heads up, eslint-plugin-cypress doesn't support ESLint v8. So, you might want to stay with 3.x until you upgrade to ESLint v9, if you haven't already.

Jackson3195 commented 3 days ago

@yusufkandemir so based on what you said I can in theory upgrade to v3.

However, when you run first install, you run into a peer dependency issue BUT as you stated, you can ignore the warning or suppress the error.

So just to confirm, in the following case, I can just force it through via the --force flag?

image

FelixNumworks commented 3 days ago

I bypassed the problem by adding this to package.json:

  "overrides": {
    "eslint-plugin-cypress": "^4.0.0" 
  },

You can replace 4.0.0 by what you need (3.6.0 for you I guess)