quasarframework / quasar-ui-qiconpicker

QIconPicker - Quasar App Extension
https://qiconpicker.netlify.app
MIT License
56 stars 19 forks source link

Update tags on icons (material) #174

Closed joshstrange closed 1 year ago

joshstrange commented 1 year ago

Is your feature request related to a problem? Please describe.

I was trying to figure out why the Material Icon search was showing different results and it appears that most of the tags that are returned by their API are not getting built into this library.

I think I tracked it down to build.material-icons-base.js Line ~96 where you are only pulling tags off the existing file in the repo and not using any of the new tags on the response from Google's endpoint.

Describe the solution you'd like

I'd like to better understand why new tags are being used and what the purpose of the build step is if it doesn't update/use tags from the response. Also I could be missing something that needs to be run to update that "input" file.

If you are ok with updating the code with the what the API spits back instead of using the existing file (again, I must be missing the purpose of using the existing file) then I'm happy to make that change and send a PR, I just wanted to ask to better understand your expectations first.

Describe alternatives you've considered

My alternative and what I'm going to ship for now is just a link to the google page and a text box where the user can paste in the icon they want.

Additional context

CleanShot 2023-01-14 at 23 39 14

CleanShot 2023-01-14 at 23 41 10

CleanShot 2023-01-14 at 23 43 01