quasibit / eleventy-plugin-schema

Eleventy plugin to generate JSON-LD structured data.

MIT License

37 stars 8 forks source link

added organiztion schema #10

Closed christopherpickering closed 2 years ago

christopherpickering commented 2 years ago

I added organization schema as an optional schema alongside the main choices (page, blog, product) so it can be included in any page where the organization data is present.

codecov[bot] commented 2 years ago

Codecov Report

Merging #10 (c68e347) into master (167f31e) will increase coverage by 0.13%. The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   95.91%   96.05%   +0.13%     
==========================================
  Files           8        9       +1     
  Lines          98      152      +54     
==========================================
+ Hits           94      146      +52     
- Misses          4        6       +2

Impacted Files	Coverage Δ
src/organization.js	`96.29% <96.29%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 167f31e...c68e347. Read the comment docs.

nunof07 commented 2 years ago

Thank you, @christopherpickering

What if no organization is provided? Is schema still valid?

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nunof07 commented 2 years ago

Refactored a bit and pushed a new version.

christopherpickering commented 2 years ago

Thank you! The schema is still valid without it. From reading around it seems like organization is primarily for the homepage, contact page, or other page about your org.

Jan 8, 2022, 1:45 AM by @.***:

Thank you, > @christopherpickering https://github.com/christopherpickering

What if no organization is provided? Is schema still valid?

— Reply to this email directly, > view it on GitHub https://github.com/quasibit/eleventy-plugin-schema/pull/10#issuecomment-1007903432> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AEHW6IVWO7I46G7KOSZ5ONDUU7TQXANCNFSM5LNOSJNA> . Triage notifications on the go with GitHub Mobile for > iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or > Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> . You are receiving this because you were mentioned.> Message ID: > <quasibit/eleventy-plugin-schema/pull/10/c1007903432> @> github> .> com>