search

quasibit / eleventy-plugin-schema

Eleventy plugin to generate JSON-LD structured data.
MIT License
37 stars 8 forks source link

added fix for #14, #16, added site search to website schema #15

Closed christopherpickering closed 2 years ago

christopherpickering commented 2 years ago

I'm not sure exactly how to text for this, the tests are already passing but probably shouldn't. I think the function parseEqual is already stripping null/undefined.

Anyways, this seems to fix it :)

Thanks!

codecov[bot] commented 2 years ago

Codecov Report

Merging #15 (736a02f) into master (46437bf) will decrease coverage by 0.69%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   95.04%   94.35%   -0.70%     
==========================================
  Files          15       17       +2     
  Lines         101      124      +23     
==========================================
+ Hits           96      117      +21     
- Misses          5        7       +2
Impacted Files Coverage Δ
src/searchAction.js 75.00% <75.00%> (ø)
src/website.js 85.71% <85.71%> (-14.29%) :arrow_down:
src/post.js 100.00% <100.00%> (ø)
src/potentialAction.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46437bf...736a02f. Read the comment docs.

christopherpickering commented 2 years ago

Thanks!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nunof07 commented 2 years ago

Thank you again. Awesome!

nunof07 commented 2 years ago

FYI there was a small issue in the demo for search action, but now fixed.

christopherpickering commented 2 years ago

Nice, thanks!