quasibit / eleventy-plugin-schema

Eleventy plugin to generate JSON-LD structured data.
MIT License
37 stars 8 forks source link

WebPage publisher’s `url` should point to `#organization` #29

Closed agarzola closed 2 years ago

agarzola commented 2 years ago

While working with this plugin I noticed that the WebPage’s publisher object is set to have "url": "https://example.com" instead of "url": "https://example.com#organization", which is the proper @id for the Organization object. You can see this in the following line:

https://github.com/quasibit/eleventy-plugin-schema/blob/ec4f146641276b6447a8d891facb889d8feb6157/src/page.js#L50

I’ll submit a PR to address this shortly.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

nunof07 commented 2 years ago

Thank you @agarzola ! There were a couple of broken tests, but I've fixed them.

agarzola commented 2 years ago

@nunof07 I appreciate you handling those! I saw the email this morning about the broken builds and tried to make time to update my PR but just couldn’t make it happen today. I appreciate the assist!

nunof07 commented 2 years ago

@agarzola all good, thank you.