add more mouse buttons - Githubissues

quasilyte / ebitengine-input

A Godot-inspired action input handling system for Ebitengine

MIT License

66 stars 8 forks source link

add more mouse buttons #30

Closed harbdog closed 10 months ago

harbdog commented 10 months ago

updating to ebitengine v2.5 which introduced more mouse button inputs
added input mouse keys for buttons 3&4, corresponding to the back/forward browser buttons

tinne26 commented 10 months ago

Probably ColorScale.ScaleWithColor() should be preferred. Also, minor, but why &c instead of just c? Is there any performance consideration I'm not aware of? (seems kinda superfluous otherwise).

quasilyte commented 10 months ago

I can merge a Scale->ScaleWithColor fix in a separate PR.

quasilyte commented 10 months ago

I wanted to stay on a pre-2.5 version in this library due to a performance regression that happened after v2.5.0-alpha.12.0.20230228174701-7c0fbce0cfd8, but I guess I'll need to update at some point anyway.

harbdog commented 10 months ago

Probably ColorScale.ScaleWithColor() should be preferred. Also, minor, but why &c instead of just c? Is there any performance consideration I'm not aware of? (seems kinda superfluous otherwise).

Good call, sorry I had only looked at what I had done in one of my projects to handle the deprecation and realized I only did it like that because that code didn't have a color object being passed around.