quat1024 / BotaniaTweaks

small tweaks to botania, such as nerfable mana fluxfields and automatable ender air
Mozilla Public License 2.0
6 stars 7 forks source link

Potentially resolve #33: trigger *_ACTIONS at postinit. #36

Closed noobanidus closed 5 years ago

noobanidus commented 5 years ago

A very simple change that could potentially resolve the opener of #33 's issue. It certainly solved my issue!

According to Jared (from CraftTweaker), the correct place to trigger actions is at postinit as JEI uses loadComplete. There's also a generic IAction list in the CraftTweaker class that can be used instead to simplify.

noobanidus commented 5 years ago

Also I pushed additional stuff without thinking so now it's a part of it. Hooray!

The other commit lets you use filled buckets and returns any non-empty buckets that were part of the recipe. It is badly coded please fix it.

noobanidus commented 5 years ago

Bump just for the JEI stuff plz.

quat1024 commented 5 years ago

Ok I made the jei stuff happen in postinit and you said it works so I'll close this

Re: buckets and container items in general I'll think about it. If you want to make a recipe with a fluid but don't want people to have to spend buckets, consider consuming the fluid in-world as part of the multiblock ;)