Closed Hubry closed 5 years ago
tyvm !! really appreciate this thanks
i will take a look in a day or 2 when i can get to a computer
nullable stacks in the jei was mainly to differentiate between "multiblock recipe block is consumed" (turns to air) and "multiblock recipe block does not change" I think, but its been a while lol. since if the block doesn't change, it doesn't make sense to list the agglo recipe as a method of crafting that item. (yes this is edgecasey bullshit which is why i hate touching it)
that code is fuckign garbage anyways though i think it was my first jei handler xd
On Jan 18, 2019 14:17, "Hubry" notifications@github.com wrote:
I guess I should've made more PRs but who got time for that, if you want just parts, cherrypick commits from my branch or something?
- Back to Botania from Jared's maven, you probably won't have to go back to libs again because it's autobuilding now.
- Bunch of warning fixes. It's mostly generics. There are 2 remaining I'm too lazy to fix or don't want to touch. Please -Xlint:all ok
- Also removed that one unused class remaining from the stuff for apothecaries that got pulled to Botania upstream
- Lexica lookup now works for crates and potatoes both in world and inventories.
- Hide compat crates when EC crafters are disabled, fixes #41 https://github.com/quat1024/BotaniaTweaks/issues/41. If you want it to not register them at all let me know. (remember when compat crates were disableable from your config?)
- Hopefully a bit less terrible stack to state conversion, fixes #43 https://github.com/quat1024/BotaniaTweaks/issues/43. Can you answer why are you using nullable stacks there? I left them nullable because it broke JEI and I am lazy.
You can view, comment on, or merge this pull request online at:
https://github.com/quat1024/BotaniaTweaks/pull/44 Commit Summary
- Maven and warning cleanups (mostly generics, unused asm stuff)
- Fix blocks not working with lexica lookup in world and inventory
- Hide compat crates when EC crafters are disabled, fixes #41
- Switch to a different stack to state conversion, dumb but fixes #43
File Changes
- M README.md https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-0 (2)
- M build.gradle https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-1 (4)
- M src/main/java/quaternary/botaniatweaks/asm/ BotaniaTweakerHooks.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-2 (7)
- M src/main/java/quaternary/botaniatweaks/modules/ avaritia/ModuleAvaritia.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-3 (5)
- M src/main/java/quaternary/botaniatweaks/modules/botania/ ModuleBotania.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-4 (4)
- M src/main/java/quaternary/botaniatweaks/modules/botania/ lexi/BotaniaLexiconHandler.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-5 (5)
- D src/main/java/quaternary/botaniatweaks/modules/botania/ misc/CatchallFlowerComponent.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-6 (18)
- M src/main/java/quaternary/botaniatweaks/modules/extendedcrafting/ ModuleExtendedCrafting.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-7 (23)
- M src/main/java/quaternary/botaniatweaks/modules/jei/ BotaniaTweaksJeiPlugin.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-8 (19)
- M src/main/java/quaternary/botaniatweaks/modules/jei/ RecipeCategoryCustomAgglomeration.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-9 (9)
- M src/main/java/quaternary/botaniatweaks/modules/shared/ block/BlockCompatCrate.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-10 (10)
- M src/main/java/quaternary/botaniatweaks/modules/shared/ config/BotaniaTweaksConfig.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-11 (2)
- M src/main/java/quaternary/botaniatweaks/modules/shared/ helper/MiscHelpers.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-12 (14)
- M src/main/java/quaternary/botaniatweaks/modules/shared/ proxy/ClientProxy.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-13 (2)
- M src/main/java/quaternary/botaniatweaks/modules/shared/ proxy/ServerProxy.java https://github.com/quat1024/BotaniaTweaks/pull/44/files#diff-14 (2)
Patch Links:
- https://github.com/quat1024/BotaniaTweaks/pull/44.patch
- https://github.com/quat1024/BotaniaTweaks/pull/44.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/quat1024/BotaniaTweaks/pull/44, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-ONeh8Hw153-5QqHp6In-pvAZ4zbkIks5vEh2_gaJpZM4aIfLf .
haha I didn't notice there was a rocket react now, github is now perfect and beautiful
I guess I should've made more PRs but who got time for that, if you want just parts, cherrypick commits from my branch or something?
-Xlint:all
ok