search

quat1024 / apathy

Apathetic Mobs but it's Overengineered
9 stars 5 forks source link

1.19.2 version broken with new Butchercraft release #25

Open brisingraerowing opened 7 months ago

brisingraerowing commented 7 months ago

This line is the culprit

Crash Log

It seems that Butchercraft sets the spawn type to null, which seems to be valid based on the @Nullable annotations in the code.

Lightman314 commented 7 months ago

This is 100% Butchercraft's issue, as the MobSpawnType input of the EntityType#spawn function is not flagged as nullable.

See my research here for the details.

quat1024 commented 7 months ago

@Nullable annotations are all stripped from Mojang's code, so in practice they're all decompiler guesswork.

This is strictly speaking not my problem - spawntype should never be null for the same reason ItemStacks shouldn't be null. There are general-use SpawnTypes for custom spawning scenarios. Regardless, Apathy could handle this more gracefully.

I haven't worked on this mod in a bit because the six dozen ForgeGradle instances take an hour+ to set up from a cold cache on my pc and it's just depressing tbh 😔

brisingraerowing commented 7 months ago

I did a local change to work around the issue (though I later removed ButcherCraft as it has other issues currently).