search

quatrope / astroalign

A tool to align astronomical images based on asterism matching
MIT License
140 stars 44 forks source link

Don't install ez_setup.py #80

Closed olebole closed 1 year ago

olebole commented 2 years ago

Hi,

I am maintaining the astroalign package in Debian.

Installing ez_setup may clash with the ez_setup package itself, or with other packages which accidently do the same. And it is not needed anyway to run astroalign. This clash was reported as Debian#1018791 and is now locally fixed in the Debian package. It may however be useful to do the same here.

Best

Ole

martinberoiz commented 2 years ago

Hi Ole, thank you for this PR. I was coincidentally trying to find the time these days to move the project to using setup.cfg and pyproject.toml. Do you need a new public release after this or can you do it from master?

olebole commented 2 years ago

I don't need a new release as I can patch locally. I already uploaded the patched version. However, this seems to show a problem (I'll report in another issue).

martinberoiz commented 2 years ago

Ok, if this is not so urgent, I'll work on it this weekend. I'll merge yours and add some more changes. I'll move away from ez_setup. The repo health is not that good tbh, I haven't maintained it properly in a while.

martinberoiz commented 2 years ago

Hi Ole,

I pushed some CI fixes to master that I think will solve the issues on this PR, would you mind rebasing this to master? Thanks.

olebole commented 2 years ago

Done.

martinberoiz commented 2 years ago

Thanks. It looks like there was some error in the tests. I'll take a look later in the week. I'm thinking I'll just go directly to a pyproject.toml/setuptools installation type if this still keeps complaining. I'll remove ez_setup either way.

martinberoiz commented 1 year ago

Sorry this took me so long, but your commit has been merged to master. I did it outside this PR, but it's merged. I'm closing this now.