quatrope / astroalign

A tool to align astronomical images based on asterism matching
MIT License
134 stars 42 forks source link

Use numpy.random.Generator.shuffle instead of np.random.shuffle #82

Closed dholzber closed 9 months ago

dholzber commented 1 year ago
  1. The current RANSAC implementation uses numpy.random.shuffle. This should be changed to instead use the updated, recommended, random Generator API (noted in the numpy docs).
  2. In addition to 1, add a random_state input parameter that can be passed down to ransac to the public API.

Note: the latest version of skimage's ransac function referenced in issue #76 accomplishes 1 and 2.

martinberoiz commented 1 year ago

Noted

martinberoiz commented 9 months ago

implemented in 2.5.0