search

quattor / CAF

Perl Common Application Framework
www.quattor.org
Other
4 stars 14 forks source link

FileWriter: use atomic write #202

Closed stdweird closed 7 years ago

stdweird commented 7 years ago

Requires #204 and #206 Fixes #148 Fixes #223 Also fixes #189

File::AtomicWrite requires 0.18, rpm can be build using cpanspec -b --packager quattor File::AtomicWrite --force

stdweird commented 7 years ago

This requires testing obviously

stdweird commented 7 years ago

@ned21 first round of remarks addressed :smile:

stdweird commented 7 years ago

@jrha Filetools used @ned21 what changes do you still need?

jouvin commented 7 years ago

I'd like to test it to see in particular if it fixes https://github.com/quattor/maven-tools/issues/139. Could we get the dependencies in quattor externals repo?

stdweird commented 7 years ago

@jouvin i mailed them to you and @jrha lasty week 😄

stdweird commented 7 years ago

@ned21 i added another commit to fix #223

ned21 commented 7 years ago

The fix to #223 is 2fee451? Can the "Fixes #223" line be added to the commit log? Also any chance of a separate PR in case this doesn't make the cut for 17.3? Then we can get the spma change merged.

stdweird commented 7 years ago

@ned21 this is not blocking the spma PR at all, the fix is just to handle the failure in cleaner way, it doesn 't fix the failure itself

stdweird commented 7 years ago

@ned21 message updated

ned21 commented 7 years ago

I'm good with this PR, waiting on @jrha to confirm the changes he requested have been made.

stdweird commented 7 years ago

rpms added to externals repo