quattor / CCM

Configuration Cache Manager
www.quattor.org
Other
3 stars 12 forks source link

FOREIGN profiles are not cleaned up #195

Open gombasg opened 5 years ago

gombasg commented 5 years ago

The documentation of fetchProfile() says:

Only a single (most recent) copy of the foreign copy will be stored: previous versions will be removed.

However, that functionality was apparently broken by commit 7bc02dd52d37731e0e969b9cc04b5ca6a5a56049 by removing this fragment:

      if ($foreign_profile) {
          $latest = 0;
          system "rm -rf $cache_root/profile.$latest";
      }

... and I did not found any replacement of this code fragment. Since we've recently done an upgrade from an ancient version of CCM on our AII servers, we've just noticed the space not getting cleaned up.

Since the code was rewritten substantially, I don't immediately see where could this old logic be re-implemented.