search

quattor / configuration-modules-core

Node Configuration Manager Components for Everyone
www.quattor.org
Other
7 stars 56 forks source link

ncm-spma: RPM package has broken/missing dependencies #1232

Open jnovy opened 6 years ago

jnovy commented 6 years ago

The diff of upstream package - ncm-spma-17.12.0-1.noarch.rpm - versus our downstream one follows:

-yum
-yum-fastestmirror
-yum-list-data
+yum >= 3.2.29
 yum-priorities
-yum-utils
+yum-utils >= 1.1.30
 yum-versionlock

It is generally a good idea to depend on yum-fastestmirror as it will benchmark and deliver content from the fastest mirror. Note yumng plugin has code depending on it.

Related to yum/yum-utils dependency - this breaks RHEL5 installations:

cat /etc/redhat-release Red Hat Enterprise Linux Server release 5.11 (Tikanga) rpm -q yum yum-utils yum-3.2.22-40.el5 yum-utils-1.1.16-21.el5

What is the problem with RHEL5 yum/yum-utils? yumng plugin works just fine on RHEL5.

Thanks, Jindrich

jrha commented 6 years ago

I assume you meant ncm-spma rather than ncm-ssh?

jnovy commented 6 years ago

You're right - it's ncm-spma, just fixed the comment. Thanks.

jrha commented 6 years ago

The ncm-spma package dependencies have essentially not changed since 13.2 and just include what is required by spma/yum.pm plus any automatically resolved dependencies.

The only hard dependencies we specify in the POM are:

<requires>
  <require>yum &gt;= 3.2.29</require>
  <require>yum-utils &gt;= 1.1.30</require>
  <require>yum-versionlock</require>
  <require>yum-priorities</require>
</requires>

I'm not sure why that version was chosen, but git blame may be enlightening. The releases are built on CentOS6 to try and maximise compatibility backwards (to EL5) and forwards (to EL7), this works out fine most of the time, but without any EL5 infrastructure to test on problems are likely to occur. It is interesting that you say the the yum-utils version "breaks RHEL5 installations" as I thought other sites had been using this with EL5 (at least since 2013).

jrha commented 6 years ago

Unfortunately the commit message doesn't explain why that version was chosen, see https://github.com/quattor/configuration-modules-core/commit/a7abed464cf026b948f0ee208b2981c19a9614fe.

jnovy commented 6 years ago

Hi James,

yum-3.2.29 was introduced via RHEL6u1 as well as yum-utils-1.1.30. Assuming we just want to remove these deps as it makes impossible to install ncm-spma from Quattor on RHEL5.

Thanks, Jindrich

jnovy commented 6 years ago

... and to add "yum-fastestmirror"